fix(@angular-devkit/build-angular): revert performance optimization causing regression #14849
+5
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ausing regression This reverts commit 10200f1. The optimization was causing regression because we didn't cherry-pick angular#14419 in patch.
clydin
approved these changes
Jun 21, 2019
CaerusKaru
reviewed
Jun 21, 2019
| if (differentialLoading) { | ||
| // For differential loading, the builder needs to created the index.html by itself |
There was a problem hiding this comment.
Suggested change
| // For differential loading, the builder needs to created the index.html by itself | |
| // For differential loading, the builder needs to create the index.html by itself |
|
Superseded by #14853 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 10200f1.
The optimization was causing regression because we didn't cherry-pick #14419 in patch.