Skip to content

feat(@schematics/angular): add skipSelector property to the component generator #14782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

feat(@schematics/angular): add skipSelector property to the component generator #14782

merged 1 commit into from
Jun 20, 2019

Conversation

mgechev
Copy link
Member

@mgechev mgechev commented Jun 15, 2019

Fix #14749

@mgechev mgechev added the target: major This PR is targeted for the next major release label Jun 15, 2019
@mgechev mgechev marked this pull request as ready for review June 17, 2019 18:08
@mgechev mgechev added the needs: discussion On the agenda for team meeting to determine next steps label Jun 17, 2019
alan-agius4
alan-agius4 approved these changes Jun 17, 2019
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Though since it adds a new option to our public API, lets make sure that we want this and everyone is happy with the naming!

Thanks.

@mgechev mgechev removed PR state: blocked needs: discussion On the agenda for team meeting to determine next steps labels Jun 20, 2019
@mgechev mgechev merged commit 302cace into angular:master Jun 20, 2019
@mgechev mgechev deleted the minko/component-skip-selector branch June 20, 2019 17:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable selector during component generation
3 participants
@mgechev @alan-agius4 @googlebot