Skip to content

Update doc to make connection of live-reload and public-host explicit #14538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2019
Merged

Update doc to make connection of live-reload and public-host explicit #14538

merged 2 commits into from
Jun 6, 2019

Conversation

jbogarthyde
Copy link
Contributor

Document the relationship of ng serve options --live-reload and --public-host.
Address Issue #8986

@jbogarthyde jbogarthyde requested a review from alan-agius4 May 28, 2019 16:39
@jbogarthyde jbogarthyde added effort1: easy (hours) target: patch This PR is targeted for the next patch release area: docs Related to the documentation labels May 28, 2019
@Splaktar Splaktar mentioned this pull request May 28, 2019
Closed
alan-agius4
alan-agius4 approved these changes May 28, 2019
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4
Copy link
Collaborator

Caretaker: kindly squash commits.

Splaktar
Splaktar approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbogarthyde jbogarthyde added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 29, 2019
@jbogarthyde jbogarthyde removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 4, 2019
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jun 4, 2019
@alexeagle alexeagle merged commit 7ef64db into angular:master Jun 6, 2019
@jbogarthyde jbogarthyde deleted the jb-ngserve-doc branch July 10, 2019 17:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Splaktar Splaktar Splaktar approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
area: docs Related to the documentation effort1: easy (hours) target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbogarthyde @alan-agius4 @Splaktar @alexeagle @googlebot