Skip to content

fix(@angular-devkit/build-angular): absolute outputPath outputs index… #14478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

fix(@angular-devkit/build-angular): absolute outputPath outputs index… #14478

merged 1 commit into from
May 21, 2019

Conversation

alan-agius4
Copy link
Collaborator

….html in wrong location

Fixes #14474

@alan-agius4 alan-agius4 requested a review from clydin May 20, 2019 14:16
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 20, 2019
alexeagle
alexeagle approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anywhere we could add the missing test?

@alan-agius4
Copy link
Collaborator Author

@alexeagle done.

@alan-agius4 alan-agius4 added this to the 8.0 milestone May 21, 2019
@mgechev mgechev merged commit b361a97 into angular:master May 21, 2019
@alan-agius4 alan-agius4 deleted the resolve-absolute-path-index branch May 21, 2019 16:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

ng build with absolute outputPath outputs index.html in wrong location
5 participants
@alan-agius4 @alexeagle @clydin @mgechev @googlebot