Skip to content

fix for #14457 - fix(@angular-devkit/build-angular): normalize sourceMap options in ka… #14466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2019
Merged

fix for #14457 - fix(@angular-devkit/build-angular): normalize sourceMap options in ka… #14466

merged 1 commit into from
May 21, 2019

Conversation

alan-agius4
Copy link
Collaborator

…rma webpack plugin

sourceMap option can be either a boolean or an object,we need to normalize it before trying to get the script value.

Fixes #14457

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 19, 2019
@alan-agius4 alan-agius4 requested a review from clydin May 19, 2019 10:00
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

@filipesilva filipesilva removed the request for review from clydin May 20, 2019 07:40
…rma webpack plugin

`sourceMap` option can be either a boolean or an object,we need to normalize it before trying to get the `script` value.

Fixes #14457
@IgorMinar IgorMinar added this to the 8.0 milestone May 20, 2019
@IgorMinar IgorMinar changed the title fix(@angular-devkit/build-angular): normalize sourceMap options in ka… fix for #14457 - fix(@angular-devkit/build-angular): normalize sourceMap options in ka… May 20, 2019
@mgechev mgechev merged commit a7f2346 into angular:master May 21, 2019
@alan-agius4 alan-agius4 deleted the sourcemaps-specs branch May 21, 2019 16:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/cli upgrade breaks karma/jasmine sourcemap reporting
5 participants