Skip to content

fix(@schematics/angular): polyfills migration leaving broken code in … #14448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2019
Merged

fix(@schematics/angular): polyfills migration leaving broken code in … #14448

merged 1 commit into from
May 17, 2019

Conversation

alan-agius4
Copy link
Collaborator

…windows

Replacment of line endings should only happen to increase the hash matches as otherwise the recorder will fail to update the correct positions

Fixes #14443

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed cla: yes labels May 16, 2019
@alan-agius4 alan-agius4 requested a review from clydin May 16, 2019 14:01
@angular angular deleted a comment from googlebot May 16, 2019
…windows

Replacment of line endings should only happen to increase the hash matches as otherwise the recorder will fail to update the correct positions

Fixes #14443
@mgechev mgechev merged commit c81adbd into angular:master May 17, 2019
@alan-agius4 alan-agius4 deleted the line-ending-polyfills-windows branch May 18, 2019 17:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng update fails to remove polyfills leaving broken code behind (8rc 4)
4 participants