Skip to content

fix(@schematics/angular): update or add module and target to non extend… #14441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2019
Merged

fix(@schematics/angular): update or add module and target to non extend… #14441

merged 1 commit into from
May 21, 2019

Conversation

alan-agius4
Copy link
Collaborator

…ed tsconfig

Fixes #14436

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 16, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva May 16, 2019 10:05
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline whether we should migrate the old single tsconfig to the new setup. We decided it was too risky now, this close to 8 final.

But that we should try and do it for 9, both for the configs and other structural changes.

@alexeagle
Copy link
Contributor

@alan-agius4 this is too risky for 8 but @StephenFluin asks, could we find the tsconfig in the old location and update the module/target setting there?

@alan-agius4
Copy link
Collaborator Author

@alexeagle thats exactly what this PR does.

@alexeagle alexeagle dismissed filipesilva’s stale review May 20, 2019 20:02

Filipe is out, and we decided not to do the thing

@alexeagle alexeagle requested review from filipesilva and removed request for filipesilva May 20, 2019 20:02
@alan-agius4 alan-agius4 added this to the 8.0 milestone May 21, 2019
@mgechev mgechev merged commit 4e693ef into angular:master May 21, 2019
@alan-agius4 alan-agius4 deleted the non-extended-tsconfig-migration branch May 21, 2019 16:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Older CLI projects don't match the tsconfig layout of newer projects
5 participants