fix(@angular/cli): prevent nested schematic execution from generating analytics #14417

clydin · 2019-05-13T23:37:39Z

… analytics Fixes angular#14190

filipesilva · 2019-05-14T18:44:29Z

LGTM but I think this only addresses one out of the three points in #14190. It shouldn't be closed just by this PR.

clydin · 2019-05-14T19:41:18Z

2nd point was addressed by #14205
3rd point was addressed by #14395 and broken out into separate issue #14355

filipesilva · 2019-05-14T20:56:52Z

Makes sense now, thanks for explaining it to me 👍

angular-automatic-lock-bot · 2019-09-13T02:42:24Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}

fix(@angular/cli): prevent nested schematic execution from generating…

fbca7ec

… analytics Fixes angular#14190

clydin added the target: patch This PR is targeted for the next patch release label May 13, 2019

googlebot added the cla: yes label May 13, 2019

clydin requested review from alexeagle and filipesilva and removed request for alexeagle May 14, 2019 13:39

filipesilva approved these changes May 14, 2019

View reviewed changes

kyliau merged commit 2908985 into angular:master May 15, 2019

clydin deleted the schematic-analytics-only branch May 15, 2019 21:20

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback