Skip to content

fix(@angular-devkit/build-angular): extract i18n should only show warnings/errors #14383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented May 9, 2019

Fixes #14373

@clydin clydin added the target: patch This PR is targeted for the next patch release label May 9, 2019
@clydin clydin requested a review from filipesilva May 9, 2019 01:07
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the logging output doesn't cantain other build messages in

it('works', async () => {
host.appendToFile('src/app/app.component.html', '<p i18n>i18n test</p>');
const run = await architect.scheduleTarget(extractI18nTargetSpec);
await expectAsync(run.result).toBeResolvedTo(jasmine.objectContaining({ success: true }));
await run.stop();
const exists = host.scopedSync().exists(extractionFile);
expect(exists).toBe(true);
if (exists) {
const content = virtualFs.fileBufferToString(host.scopedSync().read(extractionFile));
expect(content).toContain('i18n test');
}
}, 30000);
? This way we would prevent this regression from happening again.

@clydin clydin force-pushed the i18n-extract-stats branch from f3efdda to cd7eb59 Compare May 9, 2019 16:01
@clydin clydin requested a review from filipesilva May 9, 2019 16:03
@clydin
Copy link
Member Author

clydin commented May 9, 2019

Test added.

@kyliau kyliau merged commit 68bc0c7 into angular:master May 10, 2019
@clydin clydin deleted the i18n-extract-stats branch May 10, 2019 22:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different xi18n console output in CLI v7 and v8
4 participants