Skip to content

fix(@ngtools/webpack): fixes ngcc error when project name is the same… #14325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019
Merged

fix(@ngtools/webpack): fixes ngcc error when project name is the same… #14325

merged 1 commit into from
May 7, 2019

Conversation

alan-agius4
Copy link
Collaborator

… or partially the same as a module name

FIxes #14317

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 2, 2019
@alan-agius4 alan-agius4 closed this May 2, 2019
@alan-agius4 alan-agius4 reopened this May 2, 2019
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but otherwise LGTM

@alexeagle alexeagle merged commit 4263cc6 into angular:master May 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
5 participants