Skip to content

fix(@schematics/angular): reduce package installs for 8.0 migrations #14324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented May 1, 2019

At most one package manager install will now be executed for 8.0 migrations. This provides a ~30% performance improvement for a hello world project.

This provides a ~30% performance improvement for a hello world project.
@clydin clydin added the target: patch This PR is targeted for the next patch release label May 1, 2019
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexeagle alexeagle merged commit 537bf5e into angular:master May 7, 2019
@clydin clydin deleted the migrations-8-npm branch May 7, 2019 20:25
alexeagle pushed a commit that referenced this pull request May 7, 2019
…14324)

This provides a ~30% performance improvement for a hello world project.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants