Skip to content

fix(@angular-devkit/core): host.delete() completes but never emits #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019
Merged

fix(@angular-devkit/core): host.delete() completes but never emits #14242

merged 1 commit into from
Apr 23, 2019

Conversation

alan-agius4
Copy link
Collaborator

RxJS EMPTY creates an Observable that emits no items immediately emits a complete notification.

Fixes #14235

RxJS `EMPTY` creates an Observable that emits no items immediately emits a complete notification.

Fixes #14235
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 23, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva April 23, 2019 06:18
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into problems with these in the past too, thought we had fixed it already.

I'm not sure what the right thing to put in the of() is if we don't care about it, but there's only one of(undefined) and one of(true) in core, but a bunch of of(null). So maybe of(null) is a better pattern if only for consistency.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, of(null) can't be used because the expected return type is Observable<void>.

@alexeagle alexeagle merged commit 8fcf9a4 into angular:master Apr 23, 2019
@alan-agius4 alan-agius4 deleted the host-fix-delete-emit branch April 23, 2019 17:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host.delete() completes but never emits
4 participants