Skip to content

Several 8.0 Migration fixes #14238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Several 8.0 Migration fixes #14238

merged 2 commits into from
Apr 22, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 22, 2019

  • The package group format required to automatically update the builder packages was not supported until CLI 7.2. For older CLI versions performing the update, this new migration will update the builders instead. Once the CLI is updated to at least 7.2, the update algorithm itself will handle the update.

  • Skip E2E projects when migrating browserslist. These projects are not actual applications.

Fixes #14233
Fixes #14229

@clydin clydin added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Apr 22, 2019
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clydin added 2 commits April 22, 2019 14:56
…est versions

The package group format required to automatically update the builder packages was not supported until CLI 7.2.  For older CLI versions performing the update, this new migration will update the builders instead.  Once the CLI is updated to at least 7.2, the update algorithm itself will handle the update.
@clydin clydin force-pushed the migrate-builders branch from 5198cc5 to 95bf71b Compare April 22, 2019 18:56
@alexeagle alexeagle merged commit c80a92a into angular:master Apr 22, 2019
@clydin clydin deleted the migrate-builders branch April 22, 2019 20:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
4 participants