Skip to content

fix(@schematics/angular): fix paths when newProjectRoot is an empty… #14227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2019
Merged

fix(@schematics/angular): fix paths when newProjectRoot is an empty… #14227

merged 1 commit into from
Apr 22, 2019

Conversation

alan-agius4
Copy link
Collaborator

… string

When newProjectRoot the paths are prefixed with an / example /project-name/tsconfig.lib.json which results in these being marked as absolute paths, which causes build failures.

Fixes #14108

… string

When `newProjectRoot` the paths are prefixed with an `/` example `/project-name/tsconfig.lib.json` which results in these being marked as absolute paths, which causes build failures.

Fixes #14108
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 22, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva April 22, 2019 09:29
@alexeagle alexeagle merged commit a464c00 into angular:master Apr 22, 2019
@alan-agius4 alan-agius4 deleted the empty-project-root branch April 23, 2019 04:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"newProjectRoot": "./" throws error
4 participants