fix(@angular-devkit/build-angular): resolve fonts with space in filename #13903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the uri of the font instead of spaced it will be `%20`, hence we need to decode it first before trying to resolve it. Fixes #9648
alan-agius4
added
the
target: major
|
Targeting master only as it's won't apply cleanly on the patch branch due to the new specs. |
filipesilva
approved these changes
Mar 13, 2019
filipesilva
suggested changes
Mar 13, 2019
packages/angular_devkit/build_angular/test/browser/styles2_spec_large.ts
Show resolved
Hide resolved
filipesilva
approved these changes
Mar 13, 2019
…thand is used At the moment when `font` shorthand property is used a warning is emitted when using this syntax ``` font: 10px "Font Awesome"; ``` This should be addressed by clean-css Fixes #9648
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the uri of the font instead of spaced it will be
%20, hence we need to decode it first before trying to resolve it.Fixes #9648