fix(@angular-devkit/build-angular): shim node events builtin for dev server #13725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
fix-pnpm
branch
2 times, most recently
from
17cae38 to
a627649
Compare
…server The dev server requires a node 'events' builtin shim to function. The dev server as written only currently works with package managers that hoist the `events` shim package to an accessible location. Hoisting is unfortunately not standardized and the assumption within the dev server will not hold true for all package managers. Closes angular#13680
filipesilva
suggested changes
Feb 20, 2019
There was a problem hiding this comment.
This sounds like the kind of thing that should be fixed on the webpack dev server.
We can work around it here while it get fixed, but this isn't a workaround we should keep around indefinitely because it can lead to user apps working on serve but not on prod.
Is there a tracking issue on the webpack dev server that we can follow and reference here?
|
Closing; as I am attempting to get this addressed directly in Webpack. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev server requires a node 'events' builtin shim to function. The dev server as written only currently works with package managers that hoist the
eventsshim package to an accessible location. Hoisting is unfortunately not standardized and the assumption within the dev server will not hold true for all package managers. The actual code is only accessed when hmr is enabled which allows the 'events' import to be ignored in the non-hmr case.Closes #13680