fix(@schematics/angular): findModuleFromOptions not handling proper…
#13720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
commented
Feb 20, 2019
| @@ -111,12 +111,20 @@ describe('find-module', () => { | |||
| expect(modPath).toEqual('/projects/my-proj/src/app.module.ts' as Path); | |||
| }); | |||
|
|
|||
| it('should find a module if nameFormatter is provided', () => { | |||
There was a problem hiding this comment.
this test was actually not testing the correct usecase, as nameFormatter was only used when name is provided
clydin
reviewed
Feb 20, 2019
clydin
approved these changes
Feb 20, 2019
…ly different casing in name At the moment users can have various casing and seperatirs in paths, we should not always dasherize the name when resolving modules. As for example when providing something like: ``` /module/SubModule/feature ``` It won't be able to resolve the modules properly as `sub-module` does't exist. This PR also updates the test for underscore as previously it was not properly testing this usercase, since the formatter was used on name and not th path. Fixes #13714
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly different casing in name
At the moment users can have various casing and separators in paths, we should not always dasherize the name when resolving modules.
As for example when providing something like:
It won't be able to resolve the modules properly as
sub-moduledoes't exist.This PR also updates the test for underscore as previously it was not properly testing this usercase, since the formatter was used on name and not th path.
Fixes #13714