Skip to content

fix(@ngtools/webpack): don't load ngfactories for lazy routes with Ivy #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Feb 13, 2019

Supersedes #13524

@filipesilva
Copy link
Contributor Author

filipesilva commented Feb 13, 2019

Related to angular/angular#28685

@filipesilva filipesilva changed the title fix(@ngtools/webpack): don't load ngfactories with Ivy fix(@ngtools/webpack): don't load lazy ngfactories with Ivy Feb 15, 2019
@filipesilva filipesilva changed the title fix(@ngtools/webpack): don't load lazy ngfactories with Ivy fix(@ngtools/webpack): don't load ngfactories for lazy routes with Ivy Feb 15, 2019
@filipesilva filipesilva requested a review from clydin February 15, 2019 18:03
@filipesilva filipesilva force-pushed the ivy-no-ngfactories branch 2 times, most recently from a20d80e to 5c387ed Compare February 15, 2019 18:04
@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Feb 15, 2019
@alexeagle alexeagle merged commit 91f5be7 into angular:master Feb 15, 2019
@filipesilva filipesilva deleted the ivy-no-ngfactories branch February 19, 2019 18:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants