fix(@angular-devkit/build-angular): error when both baseUrl and devServerTarget are used in protractor
#13614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
commented
Feb 7, 2019
| @@ -81,7 +85,7 @@ export class ProtractorBuilder implements Builder<ProtractorBuilderOptions> { | |||
| } | |||
|
|
|||
| // Compute baseUrl from devServerOptions. | |||
| if (options.devServerTarget && builderConfig.options.publicHost) { | |||
| if (builderConfig.options.publicHost) { | |||
There was a problem hiding this comment.
This method is never called when options.devServerTarget is falsy
filipesilva
suggested changes
Feb 7, 2019
alan-agius4
added
the
needs: discussion
mgechev
removed
the
needs: discussion
added 2 commits
February 8, 2019 07:53
…vServerTarget` are used in protractor Users cannot use both baseUrl and devServerTarget, and the later superseeds the baseUrl. Fixes #13611
Users should use baseUrl property in the Protractor config file
|
@filipesilva, PR updated following the team meeting I left the error message, as it's best to error out rather than have undefined behaviour, for the time being until this option is removed. |
filipesilva
approved these changes
Feb 8, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@angular-devkit/build-angular): error when both
baseUrlanddevServerTargetare used in protractorUsers cannot use both baseUrl and devServerTarget, and the later superseeds the baseUrl.
Fixes #13611