Skip to content

fix(@angular-devkit/build-angular): use sourcemap object in karma plugin #13584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

fix(@angular-devkit/build-angular): use sourcemap object in karma plugin #13584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/angular_devkit/build_angular/src/angular-cli-files/plugins/karma.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { statsErrorsToString } from '../utilities/stats';
import { getWebpackStatsConfig } from '../models/webpack-configs/stats';
import { createConsoleLogger } from '@angular-devkit/core/node';
import { logging } from '@angular-devkit/core';
import { WebpackTestOptions } from '../models/build-options';

/**
* Enumerate needed (but not require/imported) dependencies from this file
Expand Down Expand Up @@ -63,7 +64,7 @@ const init: any = (config: any, emitter: any, customFileHandlers: any) => {
` be used from within Angular CLI and will not work correctly outside of it.`
)
}
const options = config.buildWebpack.options;
const options = config.buildWebpack.options as WebpackTestOptions;
const logger: logging.Logger = config.buildWebpack.logger || createConsoleLogger();
successCb = config.buildWebpack.successCb;
failureCb = config.buildWebpack.failureCb;
Expand All @@ -77,7 +78,7 @@ const init: any = (config: any, emitter: any, customFileHandlers: any) => {
}

// Add a reporter that fixes sourcemap urls.
if (options.sourceMap) {
if (options.sourceMap.scripts) {
config.reporters.unshift('@angular-devkit/build-angular--sourcemap-reporter');

// Code taken from https://github.com/tschaub/karma-source-map-support.
Expand Down