fix(@ngtools/webpack): provide a TS-like path to ngProgram.listLazyRo… #13532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
approved these changes
Jan 28, 2019
filipesilva
added
the
target: patch
alan-agius4
approved these changes
Jan 28, 2019
filipesilva
added
target: major
…utes The webpack plugin was leaking our internal Path abstraction to the Angular compiler via the `ngProgram.listLazyRoutes` call. This Path abstraction is provided by `@angular-devkit/core` and shouldn't leak. Instead a TS-like path should be provided to the Angular program. Fix angular#13531
filipesilva
force-pushed
the
ngtools-path-list-lazy
branch
from
4966706 to
d3417a4
Compare
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 5, 2019
…`ngtsc` Related: angular/angular-cli#13532 Jira issue: FW-860
Closed
6 tasks
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 6, 2019
…`ngtsc` Related: angular/angular-cli#13532 Jira issue: FW-860
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 7, 2019
…`ngtsc` Related: angular/angular-cli#13532 Jira issue: FW-860
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 7, 2019
…`ngtsc` Related: angular/angular-cli#13532 Jira issue: FW-860
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 7, 2019
…`ngtsc` Related: angular/angular-cli#13532 Jira issue: FW-860
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Feb 11, 2019
…`ngtsc` Related: angular/angular-cli#13532 Jira issue: FW-860
mhevery
pushed a commit
to angular/angular
that referenced
this pull request
Feb 12, 2019
…`ngtsc` (#28542) Related: angular/angular-cli#13532 Jira issue: FW-860 PR Close #28542
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…utes
The webpack plugin was leaking our internal Path abstraction to the Angular compiler via the
ngProgram.listLazyRoutescall.This Path abstraction is provided by
@angular-devkit/coreand shouldn't leak. Instead a TS-like path should be provided to the Angular program.Fix #13531