fix(@angular/cli): schematics commands should fail on unknown options #13480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
When an addition argument is parsed the schematic commands should fail with an error. Fixes #12549
clydin
added
target: major
clydin
approved these changes
Jan 29, 2019
|
caretaker: this is for version 8 |
hansl
reviewed
Jan 30, 2019
| @@ -437,6 +437,15 @@ export abstract class SchematicCommand< | |||
| args = await this.parseArguments(schematicOptions || [], o); | |||
| } | |||
|
|
|||
| // ng-add is special because we don't know all possible options at this point | |||
| if (args['--'] && schematicName !== 'ng-add') { | |||
There was a problem hiding this comment.
Instead of doing schematicName == ng-add why not use a this.validateAdditionalArgs() or maybe a allowAdditionalArgs getter that is false for the base command class, true for add?
People can still ng generate something:ng-add and it would trigger this condition.
There was a problem hiding this comment.
Will follow up on this as I like the idea.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an addition argument is parsed the schematic commands should fail with an error.
Fixes #12549