Skip to content

Support mixing configurations #13370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions packages/angular_devkit/architect/src/architect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,24 +197,32 @@ export class Architect {
const {
project: projectName,
target: targetName,
configuration: configurationName,
configuration: configurationSpecifier,
overrides,
} = targetSpec;

const configurationNames = configurationSpecifier
? configurationSpecifier.split(',').filter(Boolean)
: [];

const project = this._workspace.getProject(projectName);
const target = this._getProjectTarget(projectName, targetName);
const options = target.options;
let configuration: TargetConfiguration = {};
const configurations: TargetConfiguration[] = [];

if (configurationName) {
if (configurationNames && configurationNames.length) {
if (!target.configurations) {
throw new ConfigurationNotFoundException(projectName, configurationName);
throw new ConfigurationNotFoundException(projectName, configurationNames[0]);
}

configuration = target.configurations[configurationName];
for (const configurationName of configurationNames) {
const configuration = target.configurations[configurationName];

if (!configuration) {
throw new ConfigurationNotFoundException(projectName, configurationName);
}

if (!configuration) {
throw new ConfigurationNotFoundException(projectName, configurationName);
configurations.push(configuration);
}
}

Expand All @@ -225,7 +233,7 @@ export class Architect {
builder: target.builder,
options: {
...options,
...configuration,
...Object.assign({}, ...configurations),
...overrides as {},
} as OptionsT,
};
Expand Down
11 changes: 11 additions & 0 deletions packages/angular_devkit/architect/src/architect_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ describe('Architect', () => {
prod: {
optionalBrowserOption: false,
},
another: {
optionalBrowserOption: true,
anotherOptionalBrowserOption: true,
},
},
},
badBrowser: {
Expand Down Expand Up @@ -74,6 +78,13 @@ describe('Architect', () => {
expect(builderConfig.options.optionalBrowserOption).toBe(false);
});

it('mixes configurations', () => {
const targetSpec = { project: 'app', target: 'browser', configuration: 'prod,another' };
const builderConfig = architect.getBuilderConfiguration<BrowserTargetOptions>(targetSpec);
expect(builderConfig.options.optionalBrowserOption).toBe(true);
expect(builderConfig.options.anotherOptionalBrowserOption).toBe(true);
});

it('lists targets by name', () => {
expect(architect.listProjectTargets('app')).toEqual(['browser', 'badBrowser', 'karma']);
});
Expand Down
1 change: 1 addition & 0 deletions packages/angular_devkit/architect/test/browser/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const failBuildEvent: BuildEvent = {
export interface BrowserTargetOptions {
browserOption: number;
optionalBrowserOption: boolean;
anotherOptionalBrowserOption: boolean;
}

export default class BrowserTarget implements Builder<BrowserTargetOptions> {
Expand Down
5 changes: 5 additions & 0 deletions packages/angular_devkit/architect/test/browser/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
"type": "boolean",
"description": "A non-required option with a default",
"default": false
},
"anotherOptionalBrowserOption": {
"type": "boolean",
"description": "Another non-required option with a default",
"default": false
}
},
"additionalProperties": false,
Expand Down