Skip to content

fix(@angular-devkit/build-angular): output non human readable lint re… #13168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2018
Merged

fix(@angular-devkit/build-angular): output non human readable lint re… #13168

merged 1 commit into from
Dec 12, 2018

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 11, 2018

…sult

At the moment, when the tslint formatted is non human readable, it is being fully silenced.

This changes this behaviour and only emit the formatted result.

Originally reported in #tools-cli-discuss

//cc @FrozenPandaz

Fixes #13173

@alan-agius4 alan-agius4 requested a review from hansl December 11, 2018 10:55
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 11, 2018
@FrozenPandaz
Copy link
Contributor

LGTM! Fixes #13173

…sult

At the moment, when the tslint formatted is non human readable, it is being fully silenced.

This changes this behaviour and only emit the formatted result.

Fixes #13173
@alan-agius4 alan-agius4 requested review from filipesilva and removed request for hansl December 11, 2018 19:59
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Dec 12, 2018
@kyliau kyliau merged commit 4296257 into angular:master Dec 12, 2018
@alan-agius4 alan-agius4 deleted the fix_lint_non_human branch December 12, 2018 19:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tslint output is fully silenced for non human readable formats
6 participants