Skip to content

fix(@angular-devkit/core): handle drive only paths in windows #12951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix(@angular-devkit/core): handle drive only paths in windows #12951

merged 1 commit into from
Nov 14, 2018

Conversation

alan-agius4
Copy link
Collaborator

When normalized path will not have a trailing slash, and at the moment the RegExp for drive needs to match \c\

Fixes #12670

When normalized path will not have a trailing slash, and at the moment the RegExp for drive needs to match `\c\`

Fixes #12670
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@kyliau kyliau merged commit a2aba28 into angular:master Nov 14, 2018
@alan-agius4 alan-agius4 deleted the fix_windows_drive_path branch November 14, 2018 21:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I created a new project but there was a problem - Unhandled 'error' event
4 participants