lint non human readable formatters produces invalid output

[alan-agius4]

refactor(@angular/cli): move project name being linted logic to builder
fix(@angular-devkit/build-angular): lint non human readable formatters produces invalid output
feat(@angular-devkit/architect): add projectName to BuilderConfiguration

fixes #12674

[filipesilva]

@hansl is working on the Architect public API and I wonder if these changes run contrary or are subsumed in his plans. @hansl can you have a look?

[hansl]

This looks good. Shouldn't the fix() commit be also part of the patch?

[hansl]

Actually, I think this feature is not something we want. Why not use the projectName that's used to call the linter? Seems like an anti-pattern we should not promote to have the projectName be part of the builder configuration, since there's already a projectName in the target spec. @filipesilva what do you think?

[clydin]

The full project definition should really be made available to the builder. The builder is, after all, acting on the project.

[alan-agius4]

@hans, I didn't mark it as there is also a feat commit since I added a new option to the API

[filipesilva]

@hansl I don't think the builder ever sees the target spec.

[alan-agius4]

Yeah, target spec is not passed to the builders, maybe we should pass this instead?

Also thinking about it, maybe instead of projectName I should name this project for consistence if accepted.

[hansl]

Yeah it should definitely not be an option. We should find a way to pass that in (the new Architect API will pass in the project and the workspace).

[alan-agius4]

Note: Pass TargetSpecifier in BuilderContext

[ngbot]

	Artifact	Baseline	Current	Change
❕	cli/new-production/test-project/main.js	173.60KB	174.25KB	+661 bytes

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}