Skip to content

Add and edit docs for generate subcommands #12743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jbogarthyde
Copy link
Contributor

@jbogarthyde jbogarthyde commented Oct 24, 2018

WIP - transfer edited doc content for generation schematics from draft to source files

@@ -15,18 +16,18 @@
},
"spec": {
"type": "boolean",
"description": "Specifies if a spec file is generated.",
"description": "When true (the default), generates a \"spec.ts\" test file for the new guard.",
Copy link
Collaborator

@alan-agius4 alan-agius4 Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would be nice to have the same descriptions for the same flag.

For instance sometimes, it is "When true, generates... and sometimes it is When true (the default), generates ..`

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Small NIT.

@alan-agius4
Copy link
Collaborator

@jbogarthyde, Can you please rebase?

@jbogarthyde jbogarthyde force-pushed the jb-subcommand-doc branch 2 times, most recently from 249b8b4 to 1fa8658 Compare October 25, 2018 15:52
"properties": {
"projectRoot": {
"description": "The root directory of the new application.",
"description": "The root folder of the new app.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit, but in general we use directory instead of folder as terminology

Copy link
Contributor Author

@jbogarthyde jbogarthyde Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jury is out on this one. I tend to prefer folder.
@jenniferfell
The Author's Style Guide does not address the issue -- and in fact, that page uses "folder" 19 times and "directory" 12 times - sometimes in the same sentence.

From Google Developer's Style Guide:
directory, folder
If the context you're documenting (such as an IDE's GUI) uses one term or the other, use that term. If not, then use directory in a command-line context, and folder in a GUI context. When in doubt, default to directory.

I guess that means this reference doc should use directory.

@jbogarthyde jbogarthyde mentioned this pull request Nov 1, 2018
@jbogarthyde
Copy link
Contributor Author

Moved these commits to docs-preview branch - PR Docs preview #12837

@jbogarthyde jbogarthyde closed this Nov 1, 2018
@jbogarthyde jbogarthyde deleted the jb-subcommand-doc branch November 1, 2018 18:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants