Skip to content

Edit and expand command docs #12741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

jbogarthyde
Copy link
Contributor

This one is just the top-level commands. Will do separate PR for subcommands (generation schematics).

@jbogarthyde jbogarthyde added effort1: easy (hours) area: docs Related to the documentation area: @angular/cli target: patch This PR is targeted for the next patch release labels Oct 24, 2018
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. 3 comments by Alan and I.

@jbogarthyde
Copy link
Contributor Author

jbogarthyde commented Oct 25, 2018

Please provide an example using the run command with the universal target. I would like to add it to the long description:
"Additional predefined Architect targets are available that do not correspond to CLI commands. For example, ..."

@alan-agius4
Copy link
Collaborator

@jbogarthyde that would be

ng run <project>:server

// prod
ng run <project>:server:production 

@jbogarthyde
Copy link
Contributor Author

@hansl I have addressed your requested changes - please check and remove blocker.
@alan-agius4
Do either of you know why it's failing continuous-integration?

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Left one small comment.

@jbogarthyde jbogarthyde mentioned this pull request Nov 1, 2018
@jbogarthyde
Copy link
Contributor Author

Moved these commits to docs-preview branch - PR Docs preview #12837

@jbogarthyde jbogarthyde closed this Nov 1, 2018
@jbogarthyde jbogarthyde deleted the jb-doc-edit branch November 1, 2018 18:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli area: docs Related to the documentation effort1: easy (hours) target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants