Skip to content

fix(@angular/cli): do not check if node_modules are inside sources dir #12372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular/cli): do not check if node_modules are inside sources dir #12372

wants to merge 1 commit into from

Conversation

nicolas-geniteau
Copy link

It should not verify that angular and rxjs packages are inside project
directory. To correctly resolve packages is enough.

Close #11685

Signed-off-by: Nicolas Geniteau [email protected]

It should not verify that angular and rxjs packages are inside project
directory. To correctly resolve packages is enough.

Close #11685

Signed-off-by: Nicolas Geniteau <[email protected]>
@nicolas-geniteau nicolas-geniteau changed the title Fix(@angular/cli): do not check if node_modules are inside sources dir fix(@angular/cli): do not check if node_modules are inside sources dir Sep 26, 2018
@hansl
Copy link
Contributor

hansl commented Sep 26, 2018

Hi @nicolas-geniteau ,

This change has been already covered by #12325.

Thanks.

@hansl hansl closed this Sep 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos)
3 participants