Skip to content

chore: update index.html to reflect alpha router changes. #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: update index.html to reflect alpha router changes. #1235

wants to merge 1 commit into from

Conversation

JC-Pergite
Copy link

@JC-Pergite JC-Pergite commented Jun 28, 2016

Base href has not been updated; it continues to show the deprecated "/" which should be as per official docs.
This change might also prevent possible issues with certain file:// protocol.

@JC-Pergite JC-Pergite changed the title chore(index.html): update base href to '.' from deprecated '/' chore: update index.html to reflect alpha router changes. Jun 28, 2016
@filipesilva
Copy link
Contributor

Can you also update the regex in https://github.com/angular/angular-cli/blob/master/addon/ng2/commands/github-pages-deploy.ts#L174 to search for your updated version?

@JC-Pergite JC-Pergite closed this Jul 7, 2016
@JC-Pergite
Copy link
Author

Sorry, had been thrown off by what turned out to be an Angular issue, which a PR that appeared after mine brought up, explained and corrected. Thanks!

Aforementioned PR: angular/angular.io#1799

@JC-Pergite
Copy link
Author

Sorry about that! Turns out an Angular issue got me a bit mixed up, and the
awesomeness that is Angular CLI was just fine!

Really appreciate what you guys are doing - it's outstanding.

On Sun, Jul 3, 2016 at 8:47 PM, Filipe Silva [email protected]
wrote:

Can you also update the regex in
https://github.com/angular/angular-cli/blob/master/addon/ng2/commands/github-pages-deploy.ts#L174
to search for your updated version?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1235 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AO-FzbW4DzANRVsMIPkh7Utu41Q35XA1ks5qSFgTgaJpZM4JAbSv
.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants