-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular-devkit/build-angular): fix duplicate lint messages #11636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking it until a repro is shown in the original issue.
I think you can repro if you update the lint target of the test project to this:
To fix the problem you'd need to dedupe the |
thanks for your help I managed to replicate the issue
…On Tue, 24 Jul 2018 at 11:42, Filipe Silva ***@***.***> wrote:
I think you can repro if you update the lint target of the test project to
this:
"lint": {
"builder": ***@***.***/build-angular:tslint",
"options": {
"tsConfig": [
"src/tsconfig.app.json",
"src/tsconfig.spec.json"
],
"exclude": [
"**/node_modules/**"
]
}
},
To fix the problem you'd need to dedupe the result array before reading
it around
https://github.com/angular/angular-cli/blob/d7e7cd22824e4b6349c0071326f3c0090265b469/packages/angular_devkit/build_angular/src/tslint/index.ts#L96
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11636 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQv-WmMxynCf4iHqiHhyxnNCgLoU6V0bks5uJuwegaJpZM4VcGzL>
.
|
…having multiple tsconfigs Closes #11633
runTargetSpec(host, tslintTargetSpec, undefined, DefaultTimeout, logger).pipe( | ||
tap((buildEvent) => expect(buildEvent.success).toBe(false)), | ||
tap(() => { | ||
// this is to make sure there are no duplicates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due that duplicate messages are within the same entry since under the hood we are using tslint formatter to format the messages with will convert and array of results to a string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking this on!
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #11633