Skip to content

Patching 1.3 branch with ng build breaking on uglify per 1.5 branch #11623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jellis
Copy link

@jellis jellis commented Jul 23, 2018

Whilst I'm aware we probably should be upgrading, we've got a lot of applications that are only being built with 1.3.x - until we're able to get through and test all the breakages, it'd be great if we could get this merged in (as it has been for some other branches/versions).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jellis
Copy link
Author

jellis commented Jul 23, 2018

I've since signed the CLA - the breaking tests appear to be legacy issues (which this branch is likely to be the root cause of).

@googlebot
Copy link

CLAs look good, thanks!

@jellis
Copy link
Author

jellis commented Jul 23, 2018

See #7931 for reference point.

@filipesilva
Copy link
Contributor

Hi @jellis, I'm sorry to say but version 1.3 is outside of our LTS and is not kept up to date anymore. The best I can say is that you can use something like https://github.com/ds300/patch-package to change the package in place.

@jellis
Copy link
Author

jellis commented Jul 24, 2018

Such is life.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants