Skip to content

fix(@angular-devkit/build-angular): don't add hash to lazy styles #11491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

fix(@angular-devkit/build-angular): don't add hash to lazy styles #11491

merged 1 commit into from
Jul 10, 2018

Conversation

filipesilva
Copy link
Contributor

Fix #11235

@filipesilva filipesilva mentioned this pull request Jul 7, 2018
Closed
@filipesilva filipesilva force-pushed the no-hash-lazy-styles branch from 46b292d to 9467d15 Compare July 7, 2018 12:29
clydin
clydin requested changes Jul 9, 2018
View reviewed changes
packages/angular_devkit/build_angular/src/angular-cli-files/plugins/rename-output-plugin.ts Outdated
hashFormat: HashFormat;
}

export class RemoveHashPlugin {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name doesn't match class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@filipesilva filipesilva force-pushed the no-hash-lazy-styles branch from 9467d15 to 72f53c2 Compare July 10, 2018 09:00
@clydin clydin merged commit 3529096 into angular:master Jul 10, 2018
@dpreindl dpreindl mentioned this pull request Jul 30, 2018
Closed
@filipesilva filipesilva deleted the no-hash-lazy-styles branch August 4, 2018 11:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Once I have created a lazy loaded css file, how do I lazy load it?
3 participants
@filipesilva @clydin @googlebot