feat(e2e): Added --config-file flag to e2e command #1054
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
CLAs look good, thanks! |
|
Please update this PR after rebasing on latest master |
|
Hi, |
|
I've got to dive back into it. I'm gonna rebase it this evening and update it Sent from my iPhone
|
|
Any update on when this will be merged into master? |
Allow for a user to use the optional --config flag to specify the usage of a different configuration file for Protractor end-to-end testing. This configuration file is first defined in angular-cli.json and refrenced by the key defined
|
@filipesilva removed that change and resolved the lint CI error On Mon, Nov 21, 2016 at 8:53 AM, Filipe Silva [email protected]
Marc Sensenich email: [email protected] |
There was a problem hiding this comment.
Sorry to come in late but I'm going through the PR queue now.
The idea here would be to have any config files in the angular-cli.json, correct? If so, could you update the README?
Alternatively, I could see this flag specify a file instead of a key in the configuration. What do you think?
| @@ -19,5 +19,6 @@ export default function() { | |||
| .then(() => _runServeAndE2e()) | |||
| .then(() => _runServeAndE2e('--prod')) | |||
| .then(() => _runServeAndE2e('--aot')) | |||
| .then(() => _runServeAndE2e('--aot', '--prod')); | |||
| .then(() => _runServeAndE2e('--aot', '--prod')) | |||
| .then(() => _runServeAndE2e('--config', 'config')); | |||
There was a problem hiding this comment.
Could you create an e2e that actually uses another config instead of the same default one?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This change will allow for a user to pass in a different config-file for e2e testing through the --config-file flag
Fix #976