-
Notifications
You must be signed in to change notification settings - Fork 12k
Added README.md and added eclipse workspace stuff to .gitignore #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Sorry that I took so long to get to this PR. I merged it in but changed some parts of it. I shortened the readme and added the github deploy section. I also removed a lot of the files you put in gitignore - I know it was the official gitignore for eclipse projects but a lot of those entries were only applicable for projects mixing javascript and something else. I tried to leave only the bare essential ignores for eclipse. Thanks for taking the time to help out! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@filipesilva
Here is the PR for #935 and has the following
README.md
file part of generated source.gitignore
on the generated source.