Skip to content

docs: update stories featuring bootstrap #10122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ahasall
Copy link
Contributor

@ahasall ahasall commented Mar 30, 2018

Bootstrap 4 has been released.
npm install bootstrap --save installs Bootstrap 4 instead of Bootstrap 3.
To install Boostrap 3, we should do npm install bootsrap@3

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ahasall
Copy link
Contributor Author

ahasall commented Mar 30, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@@ -22,11 +22,11 @@ With the new project created and ready you will next need to install bootstrap t
Using the `--save` option the dependency will be saved in package.json

```sh
# version 3.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we typically add instructions for adding old packages to projects? I'd suggest we remove the v.3 installation notes altogether.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are right. I updated the PR.

@@ -12,7 +12,7 @@ First install Bootstrap from `npm`:
```bash
npm install jquery --save
npm install popper.js --save

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not something you added, but can we add that neither jquery nor popper.js are needed if you pretend to use only CSS? With the current docs people tend to feel that they have to install them obligatory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with you. I will update my PR accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR. Tell me what you think about the changes.

@ahasall
Copy link
Contributor Author

ahasall commented Apr 16, 2018

@markgoho or @rafaelss95,
Is there any action I can take to improve this PR so that it can be merged ?
Thanks

@filipesilva
Copy link
Contributor

Heya, this pr is superseded by #10541.

@filipesilva filipesilva closed this May 1, 2018
@ahasall ahasall deleted the bootstrap-4 branch July 25, 2019 18:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants