-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(blueprints router): add the router #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like the idea of providing something with routing as part of the new, but am concerned that users may get annoyed of having to go in and delete a hello component every time they generate a new project. Possibly adding the idea via a command arg to either turn that generation on or off? |
+1 to adding via command arg, or maybe prompting the user? |
Maybe both (arg + prompt) meaning we can prompt the user if the arg isn't specified? (not sure how I feel about it, but open for discussion) Also, as for implementation, what about instead of adding the component to the ng2/new blueprint, how about calling the |
Good catch. Will do |
import {<%= jsComponentName %>App} from './app/<%= htmlComponentName %>'; | ||
|
||
|
||
bootstrap(<%= jsComponentName %>App); | ||
bootstrap(<%= jsComponentName %>App, [ | ||
ROUTER_PROVIDERS, provide(LocationStrategy, { useClass: HashLocationStrategy })]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should use PathLocationStrategy
@cironunes @Brocco are you happy enough with the implementation at #139? If so, I think this one can be closed. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
WIP to address #66
How far should we go with the implementation? I've tried to do as few as possible, but it would be nice to have at least one more route maybe showing the usage of
RouteParams
. WDYT?