Skip to content

Karma Tests run with --watch=true by default #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delasteve opened this issue Jun 1, 2016 · 2 comments · Fixed by #985
Closed

Karma Tests run with --watch=true by default #980

delasteve opened this issue Jun 1, 2016 · 2 comments · Fixed by #985

Comments

@delasteve
Copy link
Contributor

  1. OSX El Capitan
angular-cli: 1.0.0-beta.5
node: 5.11.1
os: darwin x64
  1. ng test
  2. No failures
  3. The README implies running ng test will only run the tests once and you need to use --watch to enable watch mode. Currently, this is not the case and you need to use --watch=false https://github.com/angular/angular-cli#running-unit-tests
    https://github.com/angular/angular-cli/blob/master/addon/ng2/commands/test.js#L14

What is the intended use? I will be glad to put a PR in for either updating the README.md or to update the ng test command.

@filipesilva
Copy link
Contributor

The README is the one wrong, the behaviour changed some time ago. I'll put up a PR with updated info.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jun 2, 2016
@hansl hansl closed this as completed in #985 Jun 2, 2016
hansl pushed a commit that referenced this issue Jun 2, 2016
devCrossNet pushed a commit to devCrossNet/universal-cli that referenced this issue Jun 9, 2016
devCrossNet pushed a commit to devCrossNet/universal-cli that referenced this issue Jun 9, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants