Skip to content

[1.5.0-rc.5] AoT error reporting is flaky #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cexbrayat opened this issue Oct 27, 2017 · 5 comments · Fixed by #8215
Closed

[1.5.0-rc.5] AoT error reporting is flaky #8228

cexbrayat opened this issue Oct 27, 2017 · 5 comments · Fixed by #8215
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@cexbrayat
Copy link
Member

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Angular CLI: 1.5.0-rc.5
Node: 8.7.0
OS: darwin x64
Angular: 5.0.0-rc.7
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

@angular/cli: 1.5.0-rc.5
@angular-devkit/build-optimizer: 0.0.31
@angular-devkit/core: 0.0.20
@angular-devkit/schematics: 0.0.34
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.0-rc.5
@schematics/angular: 0.0.48
typescript: 2.4.2
webpack: 3.8.1

Repro steps.

Build a simple component with a template like:

<div>{{ ponyModel.name }}</div>

and serve the app with ng serve

As with 1.5.0-rc.5, AoT is now the default mode, so changing the template to

<div>{{ p.name }}</div>

breaks the compilation with:

ERROR in Error at ERROR in Error at /Users/cedric/Code/ninjasquad/formation/Angular2/ponyracer/src/app/pony/pony.component.html(3,15): Property 'p' does not exist on type 'PonyComponent'.

ERROR in Error at /Users/cedric/Code/ninjasquad/formation/Angular2/ponyracer/src/app/pony/pony.component.html(3,15): Property 'p' does not exist on type 'PonyComponent'.

Note that the error is displayed twice.

But if you fix the issue, the error sticks around in the console, only once this time.

Sadly, breaking the template in another way will not be picked up by the CLI, as it will only display the old error, twice again. It won't work until ng serve is relaunched.

@filipesilva filipesilva added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix labels Oct 28, 2017
@filipesilva
Copy link
Contributor

I am working on a fix for this in #8215.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 28, 2017
These issues were fixed in Angular 5.0.0-rc.7.

Fix angular#8228
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 28, 2017
These issues were fixed in Angular 5.0.0-rc.7.

Fix angular#8228
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 28, 2017
These issues were fixed in Angular 5.0.0-rc.7.

Fix angular#8228
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 28, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 28, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 28, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 29, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 29, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 29, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 29, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 29, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 29, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 30, 2017
@filipesilva
Copy link
Contributor

@cexbrayat the fix for this is coming out as @angular/[email protected]. Please try it together with @angular/[email protected] (and other Angular packages) and let me know if you're still seeing this.

@cexbrayat
Copy link
Member Author

@filipesilva I tried with cli 1.5.0-rc.8 and ng 5.0.0-rc.9 and it does indeed fix the issue 👌

@filipesilva
Copy link
Contributor

Awesome, glad to hear it!

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Nov 2, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants