Skip to content

Barrels should export *, not Symbol names by default #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnpapa opened this issue May 18, 2016 · 4 comments · Fixed by #823
Closed

Barrels should export *, not Symbol names by default #820

johnpapa opened this issue May 18, 2016 · 4 comments · Fixed by #823

Comments

@johnpapa
Copy link
Contributor

in 1.0.0-beta4 it currently does

export {environment} from './environment';
export {HelloMobileAppComponent} from './hello-mobile.component';

Should just do

export * from './environment';
export * from './hello-mobile.component';

This way we have less to refactor if we change names without tooling and the CLI nor the user do not have to keep adding things to this file as we add exported symbols from the files.

@tapas4java
Copy link
Contributor

@johnpapa You mean only for top level barrel or all??

@johnpapa
Copy link
Contributor Author

all

@johnpapa
Copy link
Contributor Author

yay!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants