Skip to content

Not showing webpack compilation warnings #7213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gkalpak opened this issue Jul 31, 2017 · 7 comments · Fixed by #7216
Closed

Not showing webpack compilation warnings #7213

gkalpak opened this issue Jul 31, 2017 · 7 comments · Fixed by #7216
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@gkalpak
Copy link
Member

gkalpak commented Jul 31, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.3.0-rc.3
node: 6.11.1
os: win32 x64
@angular/animations: 4.3.1
@angular/cdk: 2.0.0-beta.8
@angular/common: 4.3.1
@angular/compiler: 4.3.1
@angular/core: 4.3.1
@angular/forms: 4.3.1
@angular/http: 4.3.1
@angular/material: 2.0.0-beta.8
@angular/platform-browser: 4.3.1
@angular/platform-browser-dynamic: 4.3.1
@angular/platform-server: 4.3.1
@angular/router: 4.3.1
@angular/service-worker: 1.0.0-beta.16
@angular/cli: 1.3.0-rc.3
@angular/compiler-cli: 4.3.1

Repro steps.

After upgrading to 1.3.0-rc.3 and doing some bad things, ng serve outputs:

webpack: Compiling...
webpack: Compiled with warnings.

But no warnings are printed 😞

(I encountered the issue with there changes, but any changes creating warnings should do.)

The log given by the failure.

N/A

@gkalpak
Copy link
Member Author

gkalpak commented Jul 31, 2017

cc @filipesilva

@filipesilva filipesilva self-assigned this Jul 31, 2017
@filipesilva filipesilva added command: build P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix labels Jul 31, 2017
@gkalpak
Copy link
Member Author

gkalpak commented Jul 31, 2017

(Hm...or maybe there are no warnings and the message is wrong. Not sure how to find out.)

@filipesilva
Copy link
Contributor

There are errors. Might be just a circular dependency error, but it exists. I had similar trouble last week.

@gkalpak
Copy link
Member Author

gkalpak commented Jul 31, 2017

Yeah, they were circular dependency warnings. If there are errors too, the warnings are shown along with the errors. But if there are only warnings, nothing is shown.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 31, 2017
The new function already correctly prints warnings/errors.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit that referenced this issue Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to #6989
Fix #7213
hansl pushed a commit that referenced this issue Aug 3, 2017
Errors and warnings neet to be printed separately.

Followup to #6989
Fix #7213
@Matmo10
Copy link

Matmo10 commented Aug 3, 2017

@filipesilva @hansl Could this be made configurable at all?

I have lots of the fake errors stemming from #2034, and I actually enjoyed having the warning output rather limited.

Not only did you guys bring back the first line of the warnings (how it use to be), but you also added the whole stack traces as well. So now I have a giant wall of stack traces every time I make a change.

@Vandivier
Copy link

Bump. I realize we don't want to expose webpack until 2.0, but silencing the warnings can be done without exposing webpack.

Also, what is the timeline for 2.0?

Lastly, this has some technical merit in addition to being a convenience: Right now I'm trying to debug an issue during init which throws so many warnings it pushes the error above the scrollable range for my CLI. The solution would be to use a logger, but because the err is happening in init I'm not currently able to use my logger. Totally my issue to work out but this feature would assist.

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants