Skip to content

Should platform-server be a devDep? #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justingrayston opened this issue Jul 31, 2017 · 2 comments · Fixed by #7215
Closed

Should platform-server be a devDep? #7211

justingrayston opened this issue Jul 31, 2017 · 2 comments · Fixed by #7215
Assignees
Labels
area: docs Related to the documentation help wanted

Comments

@justingrayston
Copy link
Contributor

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Repro steps.

In step 0 it states to install platform-server. For npm it uses the --save-dev flag, for yarn it doesn't use the --dev flag.

Which should it be? It should be made consistent to avoid confusion.

screen shot 2017-07-31 at 13 37 27

@filipesilva
Copy link
Contributor

Yes, it should be saved as a development dependency. Would you be available to fix this inconsistency?

You can fix it in https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/universal-rendering.md, and a good name for the commit is docs: fix universal dep save flag.

@filipesilva filipesilva self-assigned this Jul 31, 2017
@filipesilva filipesilva added help wanted area: docs Related to the documentation labels Jul 31, 2017
justingrayston added a commit to justingrayston/angular-cli that referenced this issue Jul 31, 2017
filipesilva pushed a commit that referenced this issue Aug 2, 2017
hansl pushed a commit that referenced this issue Aug 3, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to the documentation help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants