yarn fails to handle angular-cli 1.2.4 dependencies correctly #7136

rightisleft · 2017-07-25T15:09:56Z

Bug Report or Feature Request (mark with an `x`)

- [X ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.2.4
node: 6.11.1
os: linux x64
@angular/common: 4.3.1
@angular/compiler: 4.3.1
@angular/core: 4.3.1
@angular/forms: 4.3.1
@angular/http: 4.3.1
@angular/platform-browser: 4.3.1
@angular/platform-browser-dynamic: 4.3.1
@angular/router: 4.3.1
@angular/cli: 1.2.4
@angular/compiler-cli: 4.3.1

Repro steps.

package.json

...
  "private": true,
  "dependencies": {
    "@angular/common": "^4.3.1",
    "@angular/compiler": "^4.3.1",
    "@angular/core": "^4.3.1",
    "@angular/forms": "^4.3.1",
    "@angular/http": "^4.3.1",
    "@angular/platform-browser": "^4.3.1",
    "@angular/platform-browser-dynamic": "^4.3.1",
    "@angular/router": "^4.3.1",
    "@ng-bootstrap/ng-bootstrap": "^1.0.0-alpha.28",
    "@types/tinycolor": "^1.1.27",
    "angular2-loaders-css": "1.0.5",
    "cerialize": "0.1.13",
    "core-js": "^2.4.1",
    "msgpack-lite": "^0.1.26",
    "ng2-charts": "^1.6.0",
    "ng2-page-scroll": "^4.0.0-beta.3",
    "ng2-select": "^1.2.0",
    "ng2-toasty": "4.0.0",
    "puse-icons-feather": "^1.1.0",
    "reflect-metadata": "0.1.9",
    "rxjs": "^5.1.0",
    "tinycolor2": "^1.4.1",
    "ts-helpers": "1.1.1",
    "typeorm": "0.0.9",
    "typescript": "^2.2.0",
    "zone.js": "^0.7.6"
  },
  "devDependencies": {
    "@angular/cli": "^1.2.4",
    "@angular/compiler-cli": "^4.3.1",
    "@types/jasmine": "2.5.38",
    "@types/node": "6.0.42",
    "bootstrap": "4.0.0-alpha.6",
    "codelyzer": "~2.0.0-beta.1",
    "font-awesome": "4.7.0",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "2.5.0",
    "karma": "1.2.0",
    "karma-chrome-launcher": "2.0.0",
    "karma-cli": "1.0.1",
    "karma-jasmine": "1.0.2",
    "karma-remap-istanbul": "0.2.1",
    "protractor": "~4.0.13",
    "ts-node": "2.1.0",
    "tslint": "4.3.0"
  }
}

$ yarn list enhanced-resolve                                                                                                                                                                                                                                                           yarn list v0.24.6
└─ [email protected]

`$ng build --prod `

The log given by the failure.

[root@4bc7c5f8560c PiensoWeb]# ng build --prod
Hash: 381eeb7f2d84ab2dfd29
Time: 19189ms
chunk    {0} styles.ff557a508943300e7e5d.bundle.css (styles) 440 bytes {4} [initial] [rendered]
chunk    {1} main.c242e4a20e66c8a77083.bundle.js (main) 1.76 kB {3} [initial] [rendered]
chunk    {2} scripts.2264c5f19ef83b4b557f.bundle.js (scripts) 152 kB {4} [initial] [rendered]
chunk    {3} vendor.89b6466bbf579cad9ebd.bundle.js (vendor) 1.08 MB [initial] [rendered]
chunk    {4} inline.33937348cd092eeba28e.bundle.js (inline) 0 bytes [entry] [rendered]

ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/godata/pipelines/PiensoWeb/src'
 @ ./src/main.ts 4:0-74
 @ multi ./src/main.ts

Desired functionality.

When i run this on OS X it works fine.

$ng -v                                                                                                                                                                                                                                                                                        
@angular/cli: 1.2.4
node: 6.11.0
os: darwin x64
@angular/common: 4.3.1
@angular/compiler: 4.3.1
@angular/core: 4.3.1
@angular/forms: 4.3.1
@angular/http: 4.3.1
@angular/platform-browser: 4.3.1
@angular/platform-browser-dynamic: 4.3.1
@angular/router: 4.3.1
@angular/cli: 1.2.4
@angular/compiler-cli: 4.3.1

$ng build --prod                                                                                                                                                                                                                                                                          
Hash: 3b14b67673dd8ca9ba26
Time: 41531ms
chunk    {0} main.8683891522fecb4ec38d.bundle.js (main) 591 kB {3} [initial] [rendered]
chunk    {1} styles.ff557a508943300e7e5d.bundle.css (styles) 440 bytes {4} [initial] [rendered]
chunk    {2} scripts.9a8757e99ae6e1dcb456.bundle.js (scripts) 152 kB {4} [initial] [rendered]
chunk    {3} vendor.c61629386e8e347207a2.bundle.js (vendor) 4.9 MB [initial] [rendered]
chunk    {4} inline.25beaa585d007a77a7d7.bundle.js (inline) 0 bytes [entry] [rendered]

Mention any other details that might be useful.

Yarn packages && node_modules deleted and reinstall on each linux build

The text was updated successfully, but these errors were encountered:

Fayde · 2017-07-25T20:53:03Z

I had this problem this morning on windows, updating my node version to latest and the cli to 1.2.4 solved the issue, though

rightisleft · 2017-07-25T21:35:34Z

Seems like this is definitely related to enhanced-resolve

Builds that work do not have:

/Users/jmurphy/projects/ubq/web/node_modules/@ngtools/webpack/node_modules/enhanced-resolve

rightisleft · 2017-07-25T22:07:56Z

Weird - today im seeing the following on the failed builds

[me@ae7b3ab2f8b7]# yarn list enhanced-resolve @angular/cli
yarn list v0.27.5
├─ @angular/[email protected]
├─ [email protected]
└─ [email protected]
   └─ [email protected]

rightisleft · 2017-07-25T22:14:16Z

This does seem to be isolated to yarn.

Running the following works:

$ rm -rf node_modules
$ npm install
$ npm run buildprod

Running the following fails:

$ rm -rf node_modules
$ yarn install
$ npm run buildprod

The bug here is to make this work with yarn

pschmoek · 2017-07-26T07:25:53Z

yarn resolves 2 versions of enhanced-resolve.
Angular CLI uses webpack which has dependency enhanced-resolve "^3.3.0". This leads to 2 entries in yarn.lock - resolving 2 different versions of enhanced-resolve. One given to Angular CLI - the correct one 3.3.0 - and one given to webpack 3.4.1 - the faulty one.
Just run yarn and change yarn.lock by hand afterwards.

- [email protected]:
-   version "3.3.0"
-   resolved "YARN_REGISTRY_OR_YOUR_PRIVATE"
-   dependencies:
-     graceful-fs "^4.1.2"
-     memory-fs "^0.4.0"
-     object-assign "^4.0.1"
-     tapable "^0.2.5"

- enhanced-resolve@^3.3.0:
-   version "3.4.1"
-   resolved "YARN_REGISTRY_OR_YOUR_PRIVATE"
-   dependencies:
-     graceful-fs "^4.1.2"
-     memory-fs "^0.4.0"
-     object-assign "^4.0.1"
-     tapable "^0.2.7"

+ [email protected], enhanced-resolve@^3.3.0:
+   version "3.3.0"
+   resolved "YARN_REGISTRY_OR_YOUR_PRIVATE"
+   dependencies:
+     graceful-fs "^4.1.2"
+     memory-fs "^0.4.0"
+     object-assign "^4.0.1"
+     tapable "^0.2.5"

flauc · 2017-07-26T08:01:07Z

It looks like when ever I run yarn again the yarn.lock file gets rebuild. Is there a way to make this stick?

ankeshdave · 2017-07-26T08:38:12Z

@flauc did you try yarn --freeze-lock-file after modifying yarn.lock?

pschmoek · 2017-07-26T08:59:40Z

yarn only modifies yarn.lock if you add or upgrade a dependency. Running yarn does not change the yarn.lock - that is the point of having a lock file. So the fix only stops working if you upgrade @angular/cli or add webpack, etc.

flauc · 2017-07-26T09:11:44Z

It looks like only doing this prevents the yarn.lock file from being recreated:

yarn install --pure-lockfile

markmaynard · 2017-07-26T11:28:54Z

I was seeing the similar issues with enhanced-resolve yesterday with npm. It looks like the ^ dep on enhanced-resolve caused ngtools/webpack to change locally from [email protected] -> [email protected]. There must be a breaking change in enhanced-resolve somewhere.

orestes · 2017-07-26T17:54:01Z

The lockfile changes for me too if I run yarn install. It shouldn't, but it does...

zsparal · 2017-07-26T20:55:37Z

@pschmoek @flauc @orestes Yarn can regenerate the lockfile on yarn install if it

finds something in the package.json that's not in the lockfile
Cannot resolve something according to the existing yarn.lock file

I came to the same conclusion as @pschmoek regarding the workaround but you need to be mindful about how you modify the yarn.lock file. You should have 2 lines starting with enhanced-resolve:

[email protected]:
enhanced-resolve@^3.x.x:

It's important that you don't change the version in the second one when merging the two lines:

[email protected], enhanced-resolve@^3.x.x:

Yarn should not regenerate your lockfile after these modifications.

Edit: just as an example: @pschmoek's diff uses ^3.3.0 but for me, a freshly generated yarn.lock contains ^3.0.0. If I were to copy-paste the workaround from here my lockfile would also change on yarn install.

leovo2708 · 2017-07-27T02:10:34Z

Is this problem of yarn or of something? I am using yarn instead of npm because of better performance. But with npm, we get no problem in this case. I think this is not an issue of @angular CLI. Did we have to post an issue about this problem on yarn github? Or any other solutions here or come back npm?

Please give your idea. Thanks.

attilacsanyi · 2017-07-27T09:16:54Z

Hi guys!

No problem for me in case of node v8.2.1 and npm 5.3.0 after run npm i.
Problem just happen in case of yarn.

filipesilva · 2017-07-27T09:44:07Z

Hey all,

As far as I can tell, this is indeed a problem with yarn, and as @pschmoek described: given two dependencies ([email protected] and enhanced-resolve@^3.3.0), yarn resolves both 3.4.1 and 3.3.0 while npm resolved only to 3.3.0.

It's worth nothing that this only happens with newer versions of yarn. Older versions (like 0.24.6) seem to be fine:

$  rm -rf node_modules/ package-lock.json yarn.lock && npm -v && npm i && npm ls enhanced-resolve
5.3.0
# ...
[email protected] D:\sandbox\master-project
`-- @angular/[email protected]
  +-- @ngtools/[email protected]
  | `-- [email protected]
  `-- [email protected]
    `-- [email protected]  deduped

$  rm -rf node_modules/ package-lock.json yarn.lock && yarn --version && yarn && yarn list enhanced-resolve && yarn why enhanced-resolve
0.24.6
# ...
yarn list v0.24.6
└─ [email protected]
Done in 0.83s.
yarn why v0.24.6
[1/4] Why do we have the module "enhanced-resolve"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
info Reasons this module exists
   - "@angular/cli#@ngtools/webpack" depends on it
   - "@angular/cli#webpack" depends on it
Done in 0.87s.

If someone has an issue on the yarn tracker about this I'd love to have it linked here.

Currently my stance is that this is indeed a yarn problem: it is not resolving and deduping the versions properly.

I'll keep this issue opened to make it easier to direct people to it, but there is no action to take on the CLI.

EDIT: @ryzy reports that even with [email protected] the resolution is still not working: #7113 (comment)

davidmehren · 2017-07-27T10:57:05Z

@filipesilva There is a yarn issue about this, opened by @BorntraegerMarc yarnpkg/yarn#4024
They concluded that this is not a yarn problem.

BorntraegerMarc · 2017-07-27T11:00:03Z

yarnpkg/yarn#4024 FYI @filipesilva

filipesilva · 2017-07-27T11:58:46Z

Thanks @davidmehren and @BorntraegerMarc. I went through it and think there are some very good points there (reliance on hoisting and the absence of peer dependencies).

I'm trying to figure out where that leaves us and what can be done on the short term. Will update as soon as I have news.

filipesilva · 2017-07-27T16:20:04Z

We're trying to get a new fix released today (#7169), under 1.2.6/1.3.0-rc.3. We hope that it will allow [email protected] and below to resolve correctly even under yarn.

filipesilva · 2017-07-27T19:11:09Z

The versions have been released. Please let me know if you still run into problems with yarn.

cebor · 2017-07-27T19:38:50Z

Works for me.

Big Thanks @filipesilva !!!

rybaczewa · 2017-07-28T14:46:25Z

Can confirm, 1.2.5 was broken, 1.2.6 works fine for me.

orestes · 2017-07-28T16:17:12Z

@angular/cli 1.2.6 working like a charm. Thanks!

filipesilva · 2017-07-29T09:49:48Z

Closing then, this seems to be sorted.

BorntraegerMarc · 2017-07-29T11:05:19Z

@filipesilva I think you accidentally opened the issue again. It works like a charm for me now as well with yarn 0.27.5

angular-automatic-lock-bot · 2019-09-07T09:41:36Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

rightisleft changed the title ~~ng build prod works on os x and fails on linux~~ yarn fails to handle angular-cli 1.2.4 dependencies correctly Jul 25, 2017

leovo2708 mentioned this issue Jul 26, 2017

ERROR in ./src/main.ts Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' #7125

Closed

zsparal mentioned this issue Jul 26, 2017

AOT build fails #7113

Closed

filipesilva self-assigned this Jul 27, 2017

filipesilva added blocked type: faq labels Jul 27, 2017

filipesilva mentioned this issue Jul 27, 2017

Environment flags not working #7138

Closed

ghost mentioned this issue Jul 27, 2017

1.3.0-rc.1 ng build --prod fails on a project that builds fine with 1.2.5. #7161

Closed

filipesilva mentioned this issue Jul 27, 2017

--build-optimizer giving 'browser' doesn't contain a valid alias configuration error #7105

Closed

filipesilva mentioned this issue Jul 27, 2017

Support enhanced resolve #7169

Merged

silenceisgolden mentioned this issue Jul 27, 2017

Cannot import a module above the src/app folder #7087

Closed

filipesilva closed this as completed Jul 29, 2017

filipesilva reopened this Jul 29, 2017

filipesilva closed this as completed Jul 29, 2017

filipesilva removed blocked type: faq labels Aug 10, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yarn fails to handle angular-cli 1.2.4 dependencies correctly #7136

yarn fails to handle angular-cli 1.2.4 dependencies correctly #7136

rightisleft commented Jul 25, 2017 •

edited

Loading

Fayde commented Jul 25, 2017

rightisleft commented Jul 25, 2017

rightisleft commented Jul 25, 2017 •

edited

Loading

rightisleft commented Jul 25, 2017 •

edited

Loading

pschmoek commented Jul 26, 2017

flauc commented Jul 26, 2017

ankeshdave commented Jul 26, 2017 •

edited

Loading

pschmoek commented Jul 26, 2017

flauc commented Jul 26, 2017

markmaynard commented Jul 26, 2017

orestes commented Jul 26, 2017

zsparal commented Jul 26, 2017 •

edited

Loading

leovo2708 commented Jul 27, 2017

attilacsanyi commented Jul 27, 2017

filipesilva commented Jul 27, 2017 •

edited

Loading

davidmehren commented Jul 27, 2017

BorntraegerMarc commented Jul 27, 2017

filipesilva commented Jul 27, 2017

filipesilva commented Jul 27, 2017 •

edited

Loading

filipesilva commented Jul 27, 2017

cebor commented Jul 27, 2017 •

edited

Loading

rybaczewa commented Jul 28, 2017

orestes commented Jul 28, 2017

filipesilva commented Jul 29, 2017

BorntraegerMarc commented Jul 29, 2017

angular-automatic-lock-bot bot commented Sep 7, 2019

yarn fails to handle angular-cli 1.2.4 dependencies correctly #7136

yarn fails to handle angular-cli 1.2.4 dependencies correctly #7136

Comments

rightisleft commented Jul 25, 2017 • edited Loading

Bug Report or Feature Request (mark with an x)

Versions.

Repro steps.

The log given by the failure.

Desired functionality.

Mention any other details that might be useful.

Fayde commented Jul 25, 2017

rightisleft commented Jul 25, 2017

rightisleft commented Jul 25, 2017 • edited Loading

rightisleft commented Jul 25, 2017 • edited Loading

pschmoek commented Jul 26, 2017

flauc commented Jul 26, 2017

ankeshdave commented Jul 26, 2017 • edited Loading

pschmoek commented Jul 26, 2017

flauc commented Jul 26, 2017

markmaynard commented Jul 26, 2017

orestes commented Jul 26, 2017

zsparal commented Jul 26, 2017 • edited Loading

leovo2708 commented Jul 27, 2017

attilacsanyi commented Jul 27, 2017

filipesilva commented Jul 27, 2017 • edited Loading

davidmehren commented Jul 27, 2017

BorntraegerMarc commented Jul 27, 2017

filipesilva commented Jul 27, 2017

filipesilva commented Jul 27, 2017 • edited Loading

filipesilva commented Jul 27, 2017

cebor commented Jul 27, 2017 • edited Loading

rybaczewa commented Jul 28, 2017

orestes commented Jul 28, 2017

filipesilva commented Jul 29, 2017

BorntraegerMarc commented Jul 29, 2017

angular-automatic-lock-bot bot commented Sep 7, 2019

rightisleft commented Jul 25, 2017 •

edited

Loading

Bug Report or Feature Request (mark with an `x`)

rightisleft commented Jul 25, 2017 •

edited

Loading

rightisleft commented Jul 25, 2017 •

edited

Loading

ankeshdave commented Jul 26, 2017 •

edited

Loading

zsparal commented Jul 26, 2017 •

edited

Loading

filipesilva commented Jul 27, 2017 •

edited

Loading

filipesilva commented Jul 27, 2017 •

edited

Loading

cebor commented Jul 27, 2017 •

edited

Loading