Skip to content

dry run of generating a component should display updated module, but does not #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnpapa opened this issue Feb 17, 2017 · 2 comments · Fixed by #4836
Closed

dry run of generating a component should display updated module, but does not #4801

johnpapa opened this issue Feb 17, 2017 · 2 comments · Fixed by #4836

Comments

@johnpapa
Copy link
Contributor

OS?

Mac OSX

Versions.

@angular/cli: 1.0.0-beta.31
node: 6.9.1
os: darwin x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7
@angular/cli: 1.0.0-beta.31
@angular/compiler-cli: 2.4.7

Repro steps.

ng g c dashboard/foobar --dry-run

produces

installing component
You specified the dry-run flag, so no changes will be written.
  create src/app/dashboard/foo/foo.component.css
  create src/app/dashboard/foo/foo.component.html
  create src/app/dashboard/foo/foo.component.spec.ts
  create src/app/dashboard/foo/foo.component.ts

and it should have also logged

  update src/app/dashboard/dashboard.module.ts

as discussed with @filipesilva

@filipesilva
Copy link
Contributor

@Brocco can you have a look?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants