Skip to content

Default AOT to true in prod #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hansl opened this issue Jan 20, 2017 · 5 comments · Fixed by #4105
Closed

Default AOT to true in prod #4138

hansl opened this issue Jan 20, 2017 · 5 comments · Fixed by #4105
Assignees
@filipesilva

Comments

@hansl
Copy link
Contributor

hansl commented Jan 20, 2017

Just set the AOT default to true for production builds.
@filipesilva filipesilva mentioned this issue Jan 20, 2017
Merged
@tsabirgaliev
Copy link
Contributor

This + i18n can bring headaches to users

@filipesilva
Copy link
Contributor

@tsabirgaliev what problems do you predict? Mind you that it's a default, you can always do ng build prod --no-aot.

@tsabirgaliev
Copy link
Contributor

tsabirgaliev commented Jan 21, 2017 •
edited
Loading

@filipesilva Yes, you are right, actually no big problems. Just disabling AoT will solve that.

@cacogr
Copy link

cacogr commented Jan 24, 2017

The title is a bit misleading then. It probably should be "Default to AOT in prod".

filipesilva added a commit that referenced this issue Jan 24, 2017
@filipesilva
refactor(build): consolidate build options (#4105)
e15433e 
Fix #4138

BREAKING CHANGE:

- `--extractCss` defaults to `false` on all `--dev` (`ng build` with no flags uses `--dev`)
-  `--aot` defaults to true in `--prod`
- the alias for `--output-path` is now `-op` instead of `-o`
@hansl hansl changed the title Force AOT in prod Default AOT to true in prod Jan 24, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@filipesilva @MRHarrison
refactor(build): consolidate build options (angular#4105)
f946c8e 
Fix angular#4138

BREAKING CHANGE:

- `--extractCss` defaults to `false` on all `--dev` (`ng build` with no flags uses `--dev`)
-  `--aot` defaults to true in `--prod`
- the alias for `--output-path` is now `-op` instead of `-o`
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filipesilva filipesilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(build): consolidate build options filipesilva/angular-cli
4 participants
@tsabirgaliev @hansl @cacogr @filipesilva