Skip to content

Tracking: Styleguide Compliance #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
hansl opened this issue Jan 20, 2017 · 3 comments · Fixed by #4389
Closed
7 tasks done

Tracking: Styleguide Compliance #4137

hansl opened this issue Jan 20, 2017 · 3 comments · Fixed by #4389
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@hansl
Copy link
Contributor

hansl commented Jan 20, 2017

Modifications to angular-cli.json (including schema and TS definition file)

  • Reorganize by generation/blueprint (currently by configuration option)

Ensure support of the following options:

  • spec generation
  • flat folder
  • inline template (component only)
  • inline style (component only)
  • view encapsulation (component only)
  • change detection (component only)
@hansl
Copy link
Contributor Author

hansl commented Jan 20, 2017

@filipesilva filipesilva added command: generate P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 24, 2017
@filipesilva
Copy link
Contributor

Also: style guide says we separate 3rd party imports from app imports with a blank line. We should do a pass on the generated code for this.

Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 3, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 4, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 14, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 14, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Feb 14, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants