Skip to content

Setting CSS preprocessor corrupts the environment settings #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mizdler opened this issue Jan 16, 2017 · 4 comments · Fixed by #4103
Closed

Setting CSS preprocessor corrupts the environment settings #4044

mizdler opened this issue Jan 16, 2017 · 4 comments · Fixed by #4103
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@mizdler
Copy link

mizdler commented Jan 16, 2017

OS?

Mac OSX El Capitan

Versions.

angular-cli: 1.0.0-beta.25.5
node: 4.2.6
os: darwin x64
@angular/common: 2.4.3
@angular/compiler: 2.4.3
@angular/core: 2.4.3
@angular/forms: 2.4.3
@angular/http: 2.4.3
@angular/platform-browser: 2.4.3
@angular/platform-browser-dynamic: 2.4.3
@angular/router: 3.4.3
@angular/compiler-cli: 2.4.3

Repro steps.

Just create a new project and change the CSS preprocessor using cli:
ng set defaults.styleExt sass
but this corrupts environments settings in angular-cli.json:
screen shot 2017-01-16 at 3 21 43 pm
@filipesilva
Copy link
Contributor

This looks like a bug, thanks for reporting it!

@hansl this looks like an unintended side-effect of the new @ngtools/json-schema.

@filipesilva filipesilva added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix labels Jan 16, 2017
@chaouiy
Copy link

chaouiy commented Jan 16, 2017

same issue I am facing !!

@nashimus
Copy link

I just ran into this last night, glad to see someone reported it already. Thanks!

This was referenced Jan 17, 2017
Closed
Closed
hansl added a commit to hansl/angular-cli that referenced this issue Jan 18, 2017
@hansl
fix(@ngtools/json-schema): serialize object properties better.
7a40803 
The problem was that in an object that allowed additional properties, we were not serializing the object new values properly.

Fixes angular#4044.
@hansl hansl mentioned this issue Jan 18, 2017
Merged
hansl added a commit that referenced this issue Jan 18, 2017
@hansl
fix(@ngtools/json-schema): serialize object properties better. (#4103)
48d1e44 
The problem was that in an object that allowed additional properties, we were not serializing the object new values properly.

Fixes #4044.
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@hansl @MRHarrison
fix(@ngtools/json-schema): serialize object properties better. (angul…
2363064 
…ar#4103)

The problem was that in an object that allowed additional properties, we were not serializing the object new values properly.

Fixes angular#4044.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@ngtools/json-schema): serialize object properties better. hansl/angular-cli
5 participants
@hansl @nashimus @filipesilva @mizdler @chaouiy