Replace `source` in environments with separate `environmentDefault` entry #3857

filipesilva · 2017-01-04T23:19:30Z

Currently use use the source key inside the environments object to specify which file should be replaced:

"environments": {
  "source": "environments/environment.ts",
  "dev": "environments/environment.ts",
  "prod": "environments/environment.prod.ts"
}

But this is already the dev file. It would be cleaner to specify the default environment instead in a separate key:

"environmentSource": "environments/environment.ts",
"environments": {
  "dev": "environments/environment.ts",
  "prod": "environments/environment.prod.ts"
}

The text was updated successfully, but these errors were encountered:

…ronmentDefault` entry Replace `source` in environments with separate `environmentDefault` entry and updated docs to reflect this change BREAKING CHANGE: angular-cli.json has changed. A new `environmentDefault` entry replaces the previous `source` entry inside `environments`. To migrate the code follow the example below: Before: "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } After: "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } Closes angular#3857

jsanchezgarcia · 2017-01-05T21:16:49Z

I just noticed that @filipesilva was assigned to this issue. Filipe, let me know if you want me to do any modifications to my PR (or feel free to do your own and discard mine).

…ronmentDefault` entry Replace `source` in environments with separate `environmentDefault` entry and updated docs to reflect this change BREAKING CHANGE: angular-cli.json has changed. A new `environmentDefault` entry replaces the previous `source` entry inside `environments`. To migrate the code follow the example below: Before: "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } After: "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } Closes angular#3857

…fault` entry Replace source in environments with separate environmentDefault entry and updated docs to reflect this change BREAKING CHANGE: angular-cli.json has changed. A new environmentDefault entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } After: "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } Closes angular#3857

Heavily based on @ jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```

@jsanchezgarcia

Heavily based on @jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```

@jsanchezgarcia

Heavily based on @jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```

@jsanchezgarcia

Heavily based on @jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```

@jsanchezgarcia

Heavily based on @jsanchezgarcia work in #4476. Fix #3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```

@jsanchezgarcia

…ar#4705) Heavily based on @jsanchezgarcia work in angular#4476. Fix angular#3857 BREAKING CHANGE: A new environmentSource entry replaces the previous source entry inside environments. To migrate the code follow the example below: Before: ``` "environments": { "source": "environments/environment.ts", "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ``` After: ``` "environmentSource": "environments/environment.ts", "environments": { "dev": "environments/environment.ts", "prod": "environments/environment.prod.ts" } ```

angular-automatic-lock-bot · 2019-09-06T18:41:17Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva added command: build P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 4, 2017

filipesilva self-assigned this Jan 4, 2017

jsanchezgarcia mentioned this issue Jan 5, 2017

refactor(build): replace source in environments with environmentDefault entry #3870

Closed

jsanchezgarcia mentioned this issue Jan 6, 2017

refactor(build): replace source in environments with environmentDefault entry #3874

Closed

jsanchezgarcia mentioned this issue Feb 7, 2017

refactor(build): replace source in environments with `environmentDe… #4476

Closed

filipesilva mentioned this issue Feb 14, 2017

feat(@angular/cli): use environmentSource key for environments #4705

Merged

filipesilva closed this as completed in #4705 Feb 16, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `source` in environments with separate `environmentDefault` entry #3857

Replace `source` in environments with separate `environmentDefault` entry #3857

filipesilva commented Jan 4, 2017 •

edited

Loading

jsanchezgarcia commented Jan 5, 2017

angular-automatic-lock-bot bot commented Sep 6, 2019

Replace source in environments with separate environmentDefault entry #3857

Replace source in environments with separate environmentDefault entry #3857

Comments

filipesilva commented Jan 4, 2017 • edited Loading

jsanchezgarcia commented Jan 5, 2017

angular-automatic-lock-bot bot commented Sep 6, 2019

Replace `source` in environments with separate `environmentDefault` entry #3857

Replace `source` in environments with separate `environmentDefault` entry #3857

filipesilva commented Jan 4, 2017 •

edited

Loading