Skip to content

Generators should list edited files in addition to created files. #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
filipesilva opened this issue Dec 18, 2016 · 2 comments · Fixed by #3642
Closed

Generators should list edited files in addition to created files. #3624

filipesilva opened this issue Dec 18, 2016 · 2 comments · Fixed by #3642
Assignees
@Brocco
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@filipesilva
Copy link
Contributor

Currently, when running ng generate, we list the files being created.

We never list the files we edit though. This can happen when doing codegen, mostly auto-adding imports to NgModules.

Followup to #2299 (comment)

/cc @Brocco
@filipesilva filipesilva added command: generate P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Dec 18, 2016
@Brocco
Copy link
Contributor

Brocco commented Dec 19, 2016

I think this is a great idea!

@Brocco Brocco self-assigned this Dec 19, 2016
Brocco added a commit to Brocco/angular-cli that referenced this issue Dec 19, 2016
@Brocco
feat(generate): Show files updated when generating
df8f92b 
Closes angular#3624
@Brocco Brocco mentioned this issue Dec 19, 2016
Merged
hansl pushed a commit that referenced this issue Dec 20, 2016
@Brocco @hansl
feat(generate): Show files updated when generating (#3642)
c011b04 
Closes #3624
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@Brocco @MRHarrison
feat(generate): Show files updated when generating (angular#3642)
000c2c5 
Closes angular#3624
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brocco Brocco

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(generate): Show files updated when generating Brocco/angular-cli
2 participants
@Brocco @filipesilva