-
Notifications
You must be signed in to change notification settings - Fork 12k
AoTPlugin breaks with Webpack 2.2.0-rc.0 #3581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any news on that? I've the same issue |
Having the same problem would be great to get a resolution |
Also having the same issue! has anyone reverted back to an older version? |
indeed. having the same problem. I reverted from |
I have this error solved but I need to work with @hansl to fix the second error. Does anyone have an example of this plugin used outside of the CLI that I can test? |
Maybe you can try with https://github.com/angular/universal-starter |
@TheLarkInn https://github.com/daniele-zurico/webpack-aot just update the versions and is ready. |
Thank you 🤗 |
Alright I'm going to leave my findings continuously as I get them. First issue is access to resolvers needs to happen after they are created: Since I am working in the JS version and not the TS source, it may look a little different in this example but I already showed this to @hansl: var tsConfigPath = this._tsConfigPath;
var compilerOptions = this._compilerOptions;
var compilerHost = this._compilerHost;
compiler.plugin("after-resolvers", function(compiler) {
compiler.resolvers.normal.plugin('resolve', function (request, cb) {
if (request.request.match(/\.ts$/)) {
_this.done.then(function () { return cb(); });
}
else {
cb();
}
});
compiler.resolvers.normal.apply(new paths_plugin_1.PathsPlugin({
tsConfigPath: tsConfigPath,
compilerOptions: compilerOptions,
compilerHost: compilerHost
}));
}); It looks like now for some reason there is a failure to resolve the virtually created factory file: |
A bugfix release of this would be really cool. Anything on the horizon? |
@hansl do you have any information about release date? |
It's been released 2 betas ago. |
Need to use before-resolve until webpack/webpack#3641 is fixed. Fixes angular#3581 Fixes angular#3660
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
The text was updated successfully, but these errors were encountered: